Unpublishes ISL and removes unused schemadiscovery package

CHANGELOG.md

@@ -102,6 +102,10 @@ Thank you to all who have contributed!
 - **Breaking**: Removes deprecated `org.partiql.lang.syntax.SourceSpan`
 - **Breaking**: Removes deprecated `org.partiql.lang.syntax.Token`
 - **Breaking**: Removes deprecated `org.partiql.lang.syntax.TokenType`
+- **Breaking**: Stops publishing PartiQL ISL to Maven Central.
+- **Breaking**: Removes unused package `org.partiql.lang.schemadiscovery` which included unused classes of:
+  `SchemaInferencerFromExample`, `SchemaInferencerFromExampleImpl`, `TypeConstraint`, `NormalizeNullableVisitorTransform`,
+  `NormalizeDecimalPrecisionsToUpToRange`, and `IonExampleParser`.
 
 ### Security
 

lib/isl/README.md

@@ -1,4 +1,7 @@
-## PartiQL ISL Kotlin
+## PartiQL ISL Kotlin (Testing Utility)
+
+**NOTE**: PartiQL ISL is no longer published to Maven. The generated classes should only be used for
+internal testing.
 
 PartiQL ISL Kotlin provides an in-memory [Ion Schema Language](https://amzn.github.io/ion-schema/docs/spec.html) (ISL) object
 model. The open-source Kotlin implementation of ISL, [ion-schema-kotlin](https://github.com/amzn/ion-schema-kotlin) allows

lib/isl/build.gradle.kts

@@ -12,7 +12,7 @@
  * express or implied. See the License for the specific language governing
  * permissions and limitations under the License.
  */
-//
+
 plugins {
     id(Plugins.conventions)
     id(Plugins.dokka)
@@ -33,13 +33,6 @@ kotlin {
     explicitApi = null
 }
 
-publish {
-    artifactId = "partiql-isl-kotlin"
-    name = "PartiQL ISL Kotlin"
-    description = "An object model that allows for programmatic manipulation of Ion Schema Language schemas."
-    url = "https://github.com/partiql/partiql-lang-kotlin/tree/main/lib/isl"
-}
-
 pig {
     namespace = "org.partiql.ionschema.model"
 }

partiql-lang/build.gradle.kts

@@ -32,12 +32,12 @@ kotlin {
 }
 
 dependencies {
-    api(project(":lib:isl"))
     api(project(":partiql-ast"))
     api(project(":partiql-spi"))
     api(project(":partiql-types"))
     api(Deps.ionElement)
     api(Deps.ionJava)
+    api(Deps.ionSchema)
     // libs are included in partiql-lang-kotlin JAR, but are not published independently yet.
     libs(project(":partiql-parser"))
     libs(project(":partiql-plan"))
@@ -46,6 +46,7 @@ dependencies {
     implementation(Deps.kotlinReflect)
 
     testImplementation(project(":plugins:partiql-mockdb"))
+    testImplementation(project(":lib:isl"))
     testImplementation(Deps.assertj)
     testImplementation(Deps.junit4)
     testImplementation(Deps.junit4Params)

partiql-lang/src/main/kotlin/org/partiql/lang/schemadiscovery/ConstraintDiscoverer.kt → partiql-lang/src/test/kotlin/org/partiql/lang/schemadiscovery/ConstraintDiscoverer.kt

@@ -29,9 +29,54 @@ internal const val MAX_INT8 = Long.MAX_VALUE
 internal val INT2_RANGE = BigInteger.valueOf(MIN_INT2)..BigInteger.valueOf(MAX_INT2)
 internal val INT4_RANGE = BigInteger.valueOf(MIN_INT4)..BigInteger.valueOf(MAX_INT4)
 internal val INT8_RANGE = BigInteger.valueOf(MIN_INT8)..BigInteger.valueOf(MAX_INT8)
-internal val INT2_RANGE_CONSTRAINT = IonSchemaModel.build { validValues(rangeOfValidValues(numRange(numberRange(inclusive(ionInt(MIN_INT2)), inclusive(ionInt(MAX_INT2)))))) }
-internal val INT4_RANGE_CONSTRAINT = IonSchemaModel.build { validValues(rangeOfValidValues(numRange(numberRange(inclusive(ionInt(MIN_INT4)), inclusive(ionInt(MAX_INT4)))))) }
-internal val INT8_RANGE_CONSTRAINT = IonSchemaModel.build { validValues(rangeOfValidValues(numRange(numberRange(inclusive(ionInt(MIN_INT8)), inclusive(ionInt(MAX_INT8)))))) }
+internal val INT2_RANGE_CONSTRAINT = IonSchemaModel.build {
+    validValues(
+        rangeOfValidValues(
+            numRange(
+                numberRange(
+                    inclusive(
+                        ionInt(
+                            MIN_INT2
+                        )
+                    ),
+                    inclusive(ionInt(MAX_INT2))
+                )
+            )
+        )
+    )
+}
+internal val INT4_RANGE_CONSTRAINT = IonSchemaModel.build {
+    validValues(
+        rangeOfValidValues(
+            numRange(
+                numberRange(
+                    inclusive(
+                        ionInt(
+                            MIN_INT4
+                        )
+                    ),
+                    inclusive(ionInt(MAX_INT4))
+                )
+            )
+        )
+    )
+}
+internal val INT8_RANGE_CONSTRAINT = IonSchemaModel.build {
+    validValues(
+        rangeOfValidValues(
+            numRange(
+                numberRange(
+                    inclusive(
+                        ionInt(
+                            MIN_INT8
+                        )
+                    ),
+                    inclusive(ionInt(MAX_INT8))
+                )
+            )
+        )
+    )
+}
 
 /**
  * Defines how additional constraints are to be discovered. This is intended to be called by a [ConstraintInferer] for

partiql-lang/src/main/kotlin/org/partiql/lang/schemadiscovery/SchemaInferencerFromExampleImpl.kt → partiql-lang/src/test/kotlin/org/partiql/lang/schemadiscovery/SchemaInferencerFromExampleImpl.kt

@@ -15,7 +15,8 @@ import org.partiql.lang.util.stringValueOrNull
  * generated schema. The passed [schemaIds] will also be used for the generated
  * [IonSchemaModel.SchemaStatement.HeaderStatement]'s [IonSchemaModel.ImportList].
  */
-class SchemaInferencerFromExampleImpl(val typeName: String, iss: IonSchemaSystem, val schemaIds: List<String>) : SchemaInferencerFromExample {
+class SchemaInferencerFromExampleImpl(val typeName: String, iss: IonSchemaSystem, val schemaIds: List<String>) :
+    SchemaInferencerFromExample {
     private val importedTypes = schemaIds.loadImportedTypes(iss)
     private val sequenceTypes = importedTypes.loadSequenceTypes()
     private val islAnyConstraints = IonSchemaModel.build { constraintList() }