Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-117107] Discover and validate platform and device os versions #6

Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented Apr 4, 2023

@laupow laupow requested review from hugomontero and keeramis April 4, 2023 13:06
Copy link

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 I haven't worked with this repo before. I am guessing the only way to test this is through GH Actions which I am assuming you've tried. I would keep an eye out during the next device-os release to ensure the change is reflected!

@laupow
Copy link
Collaborator Author

laupow commented Apr 4, 2023

only way to test this is through GH Actions

@keeramis Testing through GH Actions is the best e2e test for this tool. There's a pipeline in this repo that does just that:

test-cloud-compile:
strategy:
matrix:
os: [ ubuntu-latest ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: ./
name: 'Cloud compile'
with:
particle-access-token: ${{ secrets.PARTICLE_ACCESS_TOKEN }}
particle-platform-name: 'argon'
sources-folder: 'test/fixtures/single-file-firmware'
test-local-compile:
strategy:
matrix:
# note - local compile only works on linux
os: [ ubuntu-latest ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: ./
name: 'Local compile'
with:
particle-platform-name: 'argon'
sources-folder: 'test/fixtures/single-file-firmware'

That pipeline doesn't currently exercise every combination of parameters, but the unit tests give us some good coverage on that front.

@laupow laupow merged commit ddb6098 into main Apr 4, 2023
@laupow laupow deleted the feature/sc-117107/need-to-lookup-and-validate-platform-build branch April 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants