Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [sc-125818] Fix auto-versioning crash on new git repo #28

Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented Mar 6, 2024

Story details: https://app.shortcut.com/particle/story/125818

The commit hash string returned by the simple git tool differs on an initial commit: it starts with a ^ and only has 7 characters of the hash (e.g., ^1234abc). Subsequent commits appear with 8 characters in the blame info (e.g., 1234abcd). We need to handle both cases.

laupow added 2 commits March 6, 2024 09:17
The commit hash string differs for an initial commit: it starts with a ^ and only has 7 characters of the hash (e.g., ^1234abc). Subsequent commits appear with 8 characters in the blame info (e.g., 1234abcd). We need to handle both cases.
@laupow laupow requested review from azenk, keeramis and hugomontero March 6, 2024 15:26
@laupow laupow merged commit 831eb38 into main Mar 6, 2024
11 checks passed
@laupow laupow deleted the bug/sc-125818/fix-auto-versioning-crash-on-new-git-repo branch March 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants