Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [sc-125817] Fix auto-version crash for deleted files #27

Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented Mar 6, 2024

Story details: https://app.shortcut.com/particle/story/125817

It fixes errors like Error: path '/path/to/repo/project-folder/application.cpp' exists on disk but not in 'a1b2c3d4e5f6'.

The bug fix is 41081c4, and most of the other changes add new debug-level log messages that can help troubleshoot issues with the auto-version feature. Users can toggle on the debug logs.

@laupow laupow requested review from keeramis and azenk and removed request for azenk and keeramis March 6, 2024 15:00
@laupow
Copy link
Collaborator Author

laupow commented Mar 6, 2024

Removing review for now -- there is one more check I want to perform first

@laupow laupow marked this pull request as draft March 6, 2024 16:50
@laupow laupow changed the title feat: [sc-125817] Fix auto-version crash for deleted files fix: [sc-125817] Fix auto-version crash for deleted files Mar 6, 2024
@laupow laupow marked this pull request as ready for review March 6, 2024 19:28
@laupow
Copy link
Collaborator Author

laupow commented Mar 6, 2024

All clear -- I ran into an issue where OSX added /private to a temp dir path, breaking the app. AFAICT, this is a quirk of local dev and won't manifest in an Action runner.

@laupow laupow requested review from azenk, hugomontero and keeramis March 6, 2024 19:30
@laupow laupow force-pushed the feature/sc-125817/add-debug-logs-for-auto-version-feature branch from 62dba59 to 1e283de Compare March 6, 2024 19:32
@laupow laupow force-pushed the feature/sc-125817/add-debug-logs-for-auto-version-feature branch from 1e283de to 0e2ba4d Compare March 6, 2024 21:58
Copy link

@hugomontero hugomontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice debug elements! Will be more easy to find the root cause when something is not working 😄

@laupow laupow merged commit e165e04 into main Mar 7, 2024
11 checks passed
@laupow laupow deleted the feature/sc-125817/add-debug-logs-for-auto-version-feature branch March 7, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants