Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-119368] Sync particle.ignore and particle.include handling with cli #22

Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented Jul 18, 2023

Story details: https://app.shortcut.com/particle/story/119368

This is a port of https://github.com/particle-iot/particle-cli/pull/646/files. This project has different toolchains, so there are more than a few differences in the code. I kept names and overall structure as similar as possible.

Previously, this project did not have tests for particle.include and particle.ignore. This functionality was broken and reported in #21

@laupow laupow requested a review from keeramis July 18, 2023 13:04
@laupow laupow force-pushed the feature/sc-119368/fix-arraytohashset-is-not-a-function-in-compile branch from 65ee10d to 2d78466 Compare July 20, 2023 11:03
Copy link

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting! LGTM

@laupow laupow merged commit 4caca02 into main Sep 21, 2023
@laupow laupow deleted the feature/sc-119368/fix-arraytohashset-is-not-a-function-in-compile branch September 21, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants