-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug objects #15
Conversation
82f0bb8
to
96946db
Compare
96946db
to
5f24b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to verify this on my mac without issues.
A couple of observations that Matt and I talked about:
- Since I had the
target
directory in my user app directory, the binaries were duplicated in the/workspace/target
and/workspace/target/target
directories. As discussed, this could be a side effect of local testing and can be ignored. - One recommendation is to use the app name instead of
workspace.bin/.hex/etc
(for example:workspace_myappname.bin
. However, I am not sure if this is a useful recommendation in terms of the github actions and if it makes more sense to do hardcoded names on these files.
Thanks for the PR! It's great to see that we are one step closer to having (publicly) available .elf files that are needed for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to verify this on my mac without issues.
A couple of observations that Matt and I talked about:
- Since I had the
target
directory in my user app directory, the binaries were duplicated in the/workspace/target
and/workspace/target/target
directories. As discussed, this could be a side effect of local testing and can be ignored. - One recommendation is to use the app name instead of
workspace.bin/.hex/etc
(for example:workspace_myappname.bin
. However, I am not sure if this is a useful recommendation in terms of the github actions and if it makes more sense to do hardcoded names on these files.
Thanks for the PR! It's great to see that we are one step closer to having (publicly) available .elf files that are needed for debugging.
Story: https://app.shortcut.com/particle/story/118223/
This PR:
artifact-path
=>firmware-path
)target-path
)How to test
Run a local compile via
env "INPUT_SOURCES-FOLDER=test/fixtures/single-file-firmware" env "INPUT_PARTICLE-PLATFORM-NAME=argon" env "INPUT_DEVICE-OS-VERSION=default" npm start
(see dev docs)target
directory with the elf, lst, hex, and map files in the folder you ran the command::set-output name=target-path::target
in the stdout/logs from the Action run