Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.11 and introduce CalVer #977

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Release 23.11 and introduce CalVer #977

merged 1 commit into from
Nov 20, 2023

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Nov 16, 2023

PR Summary

Given that it also contains the change wrt to the versioning scheme (CalVer) and more specific info on how to handle/document API breaking changes, I'd like to get some explicit eyes, comments and/or approvals on there before going ahead with the release.
ping @Yurlungur @jdolence @lroberts36 @bprather @brryan @pdmullen @forrestglines @BenWibking

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philipp, LGTM

Copy link
Collaborator

@bprather bprather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

November & May seems like a good cadence, happy with releasing now

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pgrete pgrete enabled auto-merge (squash) November 20, 2023 10:23
@pgrete pgrete merged commit 998f282 into develop Nov 20, 2023
49 checks passed
@pgrete pgrete deleted the pgrete/release-23.11 branch November 20, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants