Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forceinline par_for_inner: add meshblock version #972

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

bprather
Copy link
Collaborator

@bprather bprather commented Nov 7, 2023

This is an amendment to #967 that adds the implementation of par_for_inner in meshblock.hpp to the functions forced to be inline. It gets rid of some more warnings about non-vectorized code for me (though I haven't directly measured performance), and since it's just a call through there should be no other impact.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete enabled auto-merge (squash) November 10, 2023 15:29
@pgrete pgrete merged commit bd4c0b1 into develop Nov 10, 2023
49 checks passed
@bprather bprather deleted the fix/forcein-par-for-meshblock branch July 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants