Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dn based output trigger #1210

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Add dn based output trigger #1210

merged 6 commits into from
Nov 29, 2024

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Nov 16, 2024

PR Summary

What is says on the can (plus removed dead vtk code as I don't think we'll ever implement/reactivate it).

Still need

  • doc
  • changelog
  • tests?

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete requested a review from BenWibking November 16, 2024 14:13
BenWibking
BenWibking previously approved these changes Nov 16, 2024
@BenWibking
Copy link
Collaborator

BenWibking commented Nov 16, 2024

I can't tell whether the macOS CI failure is related or not:

The following tests FAILED:
	 68 - regression_test:boundary_exchange (Failed)
	 78 - regression_test:poisson (Failed)

It looks like some of the output files don't exist, so it might be.

@BenWibking BenWibking dismissed their stale review November 16, 2024 15:16

missed failing CI

@pgrete
Copy link
Collaborator Author

pgrete commented Nov 18, 2024

I can't tell whether the macOS CI failure is related or not:

The following tests FAILED:
	 68 - regression_test:boundary_exchange (Failed)
	 78 - regression_test:poisson (Failed)

It looks like some of the output files don't exist, so it might be.

I think the updated handling of ensuring a last time based output is written might be broken (or not behaving as before any more).
I'm investigating.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can make tests pass, LGTM. 👍 for deleting dead code.

@pgrete
Copy link
Collaborator Author

pgrete commented Nov 29, 2024

The failed tests were related to a change in logic for setting dt and tlim by default as those tests did not include a temporal driver.
I now reverted that logic to the original state (i.e., dt=0 by default, which allows for the output being triggered).
I also added changelog and doc.
If all tests pass I'm now happy to merge.

@pgrete pgrete enabled auto-merge (squash) November 29, 2024 09:06
@pgrete pgrete disabled auto-merge November 29, 2024 09:06
Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in docs. Otherwise LGTM

doc/sphinx/src/outputs.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor docs typo LGTM

@pgrete pgrete enabled auto-merge (squash) November 29, 2024 20:40
@pgrete pgrete merged commit 4cde093 into develop Nov 29, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants