Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Try to fix MPI error from particle buffer refactoring #1204

Closed
wants to merge 1 commit into from

Conversation

alexrlongne
Copy link
Collaborator

  • Call resize portion even if no particles in buffer (like old behavior)

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@alexrlongne
Copy link
Collaborator Author

Just wanted try the CI through AMD as I don't know how to do that by hand yet.

@alexrlongne alexrlongne force-pushed the particle_mpi_fix branch 2 times, most recently from b8fa4f8 to e36dd23 Compare November 4, 2024 19:50
+ Call resize portion even if no particles in buffer (like old
 behavior)
@brryan
Copy link
Collaborator

brryan commented Nov 4, 2024

@alexrlongne did you try running e.g. mpiexec -n 2 /.../build/example/particle_leapfrog/particle-leapfrog -i /.../parthenon/tst/regression/test_suites/particle_leapfrog/parthinput.particle_leapfrog parthenon/job/problem_id=gold --kokkos-map-device-id-by=mpi_rank on darwin? I guess I'm asking whether this error only shows up on amd machines, which would be surprising to me,

@alexrlongne
Copy link
Collaborator Author

Fixed in #1206

@alexrlongne alexrlongne closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants