Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Ubuntu CI image #1203

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Pin Ubuntu CI image #1203

merged 3 commits into from
Nov 1, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Oct 31, 2024

PR Summary

The docs CI is failing for everyone right now due to changes in pip versions in ubuntu-latest. Here we use a specific Ubuntu version (due to @Yurlungur I think) that fixes this.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@brryan brryan requested review from Yurlungur and pdmullen October 31, 2024 16:55
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brryan brryan enabled auto-merge (squash) October 31, 2024 17:13
@Yurlungur Yurlungur disabled auto-merge October 31, 2024 22:11
@Yurlungur Yurlungur enabled auto-merge October 31, 2024 22:11
@Yurlungur Yurlungur merged commit a5b4449 into develop Nov 1, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants