Small Bugfix: Fix an issue outputting >4GB single variables per rank #1146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parthenon_hdf5.cpp
allocates astd::vector
cache of the largest per-block variable size times the number of blocks. However, both numbers are declared asint
s, so when they are multiplied it overflows when outputting a variable of total size >4GB from a single MPI rank.Oddly, this raises the following tangentially-related error:
There are various ways of fixing this, but I chose the easy one.
PR Checklist