Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Bugfix: Prevent division by zero #1113

Merged
merged 5 commits into from
Jun 15, 2024
Merged

Small Bugfix: Prevent division by zero #1113

merged 5 commits into from
Jun 15, 2024

Conversation

lroberts36
Copy link
Collaborator

PR Summary

Remove divisions by zero that are described in #1107.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 changed the title Bugfix: Prevent division by zero Small Bugfix: Prevent division by zero Jun 13, 2024
@lroberts36 lroberts36 added the bug Something isn't working label Jun 13, 2024
pgrete
pgrete approved these changes Jun 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@BenWibking BenWibking mentioned this pull request Jun 14, 2024
Merged
12 tasks
lroberts36 and others added 2 commits June 15, 2024 10:20
@lroberts36 @pgrete
Update CHANGELOG.md
bc4872e 
Co-authored-by: Philipp Grete <pgrete@hs.uni-hamburg.de>
@lroberts36
Merge branch 'develop' into lroberts36/fix-divide-by-zero
0b61410
@lroberts36 lroberts36 enabled auto-merge June 15, 2024 16:20
@lroberts36 lroberts36 merged commit 3ad98d1 into develop Jun 15, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrete pgrete pgrete approved these changes

@BenWibking BenWibking BenWibking approved these changes

@Yurlungur Yurlungur Awaiting requested review from Yurlungur

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lroberts36 @BenWibking @pgrete