Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forest size for symmetry dimensions #1093

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix forest size for symmetry dimensions #1093

merged 2 commits into from
May 30, 2024

Conversation

lroberts36
Copy link
Collaborator

PR Summary

This PR fixes a bug in the hyper rectangular forest generation routine.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Yurlungur
Yurlungur approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this was only impacting particles since grid boundaries in symmetry directions are skipped due to the fact there are no ghosts in those directions.

@Yurlungur Yurlungur enabled auto-merge May 30, 2024 20:05
@pdmullen pdmullen disabled auto-merge May 30, 2024 20:59
@pdmullen pdmullen enabled auto-merge May 30, 2024 21:02
@pdmullen pdmullen merged commit 8b5973e into develop May 30, 2024
50 checks passed
@Yurlungur Yurlungur deleted the lroberts36/bugfix-forest-size branch June 7, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lroberts36 @Yurlungur @pdmullen