[trivial] create inner loop pattern tag manually #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
My "automatic" loop pattern fix in PR #1078 had an unexpected effect. Inner loop pattern tags, on some builds in riot, are now not being properly resolved on device. I think this is related to #321 and #319, though I'm not sure why
constexpr
isn't sufficient to make the tags get captured. The trivial solution, implemented here, is to just make the macro call the tag constructor manually. This only needs to be done forInnerLoopPatternTVR
.PR Checklist