Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host labels and an overload for operator<< in sparsepack #1068

Merged
merged 4 commits into from
May 8, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented May 2, 2024

PR Summary

I'm chasing down a bug in riot right now and it's been useful to be able to print the contents of a SparsePack object. This adds the capability to do so with a LabelHost function that can be called on host and a stream operator overload if you just want to dump the whole pack.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added the enhancement New feature or request label May 2, 2024
@Yurlungur Yurlungur self-assigned this May 2, 2024
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems very helpful

Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/interface/sparse_pack_base.cpp Show resolved Hide resolved
@Yurlungur Yurlungur enabled auto-merge May 6, 2024 17:47
@pgrete pgrete disabled auto-merge May 8, 2024 08:47
@pgrete pgrete enabled auto-merge (squash) May 8, 2024 08:47
@pgrete pgrete merged commit 650273b into develop May 8, 2024
49 of 53 checks passed
@Yurlungur Yurlungur deleted the jmm/sparse-pack-labels branch May 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants