[Trivial] Reorganize LogicalLocation code
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to merge this to the forrest branch or later (separately) into develop once forrest is merged? |
|
@pgrete: I was thinking later after the forest branch is merged. This would just make the diff even bigger I think. |
7 tasks
lroberts36
commented
Apr 1, 2024
Comment on lines
-147
to
-149
| void SetNeighbor(LogicalLocation inloc, int irank, int ilevel, int igid, int ilid, | ||
| int iox1, int iox2, int iox3, NeighborConnect itype, int ibid, | ||
| int itargetid, int ifi1 = 0, int ifi2 = 0); |
There was a problem hiding this comment.
This is no longer used anywhere (constructors are used instead), so I removed it.
lroberts36
commented
Apr 1, 2024
Comment on lines
+21
to
+22
| #ifndef MESH_FOREST_BLOCK_OWNERSHIP_HPP_ | ||
| #define MESH_FOREST_BLOCK_OWNERSHIP_HPP_ |
There was a problem hiding this comment.
This previously sat in logical_location.*
lroberts36
commented
Apr 1, 2024
| @@ -53,31 +53,6 @@ bool LogicalLocation::Contains(const LogicalLocation &containee) const { | |||
| return (shifted_lx1 == lx1()) && (shifted_lx2 == lx2()) && (shifted_lx3 == lx3()); | |||
| } | |||
|
|
|||
| std::array<int, 3> LogicalLocation::GetOffset(const LogicalLocation &neighbor, | |||
lroberts36
commented
Apr 1, 2024
Comment on lines
-361
to
-363
| // TODO(LFR): Remove this | ||
| block_ownership_t | ||
| DetermineOwnership(const LogicalLocation &main_block, |
There was a problem hiding this comment.
just moved for now, next forest PR removes this though.
pgrete
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Just move some files around and split up some files to make the code easier to navigate. Also removes a little bit of dead code.
PR Checklist