Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The client IP address may be determined incorrectly in some cases #8370

Closed
wants to merge 1 commit into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 5, 2023

Fixes security vulnerability GHSA-vm5r-c87r-pf6x.

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: release pf6x fix: Release pf6x Jan 5, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 5, 2023

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 94.13% // Head: 93.62% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (91eed72) compared to base (679c61d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 91eed72 differs from pull request most recent head 9d9d8b9. Consider uploading reports for the commit 9d9d8b9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #8370      +/-   ##
===========================================
- Coverage    94.13%   93.62%   -0.52%     
===========================================
  Files          182      182              
  Lines        13785    13779       -6     
===========================================
- Hits         12977    12900      -77     
- Misses         808      879      +71     
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/ParseServer.js 90.37% <100.00%> (+0.10%) ⬆️
src/middlewares.js 96.83% <100.00%> (-0.12%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/Routers/AggregateRouter.js 92.00% <0.00%> (-8.00%) ⬇️
src/ParseServerRESTController.js 92.42% <0.00%> (-6.07%) ⬇️
src/batch.js 89.47% <0.00%> (-3.51%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.63% <0.00%> (-2.56%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <0.00%> (-0.73%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 5, 2023

Closing; fix only needed in alpha branch as #8372 will propagate to beta and release branches with Parse Server 6 release.

@mtrezza mtrezza closed this Jan 5, 2023
@mtrezza mtrezza changed the title fix: Release pf6x fix: The client IP address may be determined incorrectly in some cases Jan 5, 2023
@mtrezza mtrezza deleted the fix-release-pf6x branch May 20, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant