-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: test moved to correct test group #7717
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #7717 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 183 183
Lines 13624 13624
==========================================
- Hits 12792 12791 -1
- Misses 832 833 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It’s a minor refactor. I discovered these changes should be made while investigating 7714 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This change has been released in version 5.0.0-alpha.9 |
🎉 This change has been released in version 5.0.0-beta.10 |
🎉 This change has been released in version 5.1.0 |
New Pull Request Checklist
Issue Description
A variable named
ors
is used in #7593 which should probably be namedands
to better represent what it's used for. In addition, the test case added is placed under thesendEmail
tests which it should be placed under otherbeforeFind
tests.Related issue: #7714
Approach
Move the added test in the same category as other
beforeFind
tests. This will make debugging failures in the future easier. Replace variable names.TODOs before merging