Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test moved to correct test group #7717

Merged
merged 7 commits into from
Nov 25, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 24, 2021

New Pull Request Checklist

Issue Description

A variable named ors is used in #7593 which should probably be named ands to better represent what it's used for. In addition, the test case added is placed under the sendEmail tests which it should be placed under other beforeFind tests.

Related issue: #7714

Approach

Move the added test in the same category as other beforeFind tests. This will make debugging failures in the future easier. Replace variable names.

TODOs before merging

  • Update tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 24, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #7717 (e820faa) into alpha (2602904) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7717      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.01%     
==========================================
  Files         183      183              
  Lines       13624    13624              
==========================================
- Hits        12792    12791       -1     
- Misses        832      833       +1     
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 93.78% <100.00%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 93.88% <0.00%> (-0.16%) ⬇️
src/ParseServerRESTController.js 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2602904...e820faa. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza
Copy link
Member

mtrezza commented Nov 25, 2021

For the record, as I understand from your comment, this PR is merely a minor refactor and not related to #7714. Is this ready for merge?

@mtrezza mtrezza changed the title refactor: clean up additions made in #7593 refactor: test moved to correct test group Nov 25, 2021
@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 25, 2021

It’s a minor refactor. I discovered these changes should be made while investigating 7714

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit c789f6c into parse-community:alpha Nov 25, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 27, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants