Support for Query IncludeAll #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4838 +/- ##
==========================================
+ Coverage 92.74% 92.77% +0.02%
==========================================
Files 119 119
Lines 8731 8751 +20
==========================================
+ Hits 8098 8119 +21
+ Misses 633 632 -1
Continue to review full report at Codecov.
|
acinader
previously approved these changes
Jun 15, 2018
spec/ParseQuery.spec.js
Outdated
| @@ -3684,6 +3684,75 @@ describe('Parse.Query testing', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it("includeAll", (done) => { | |||
There was a problem hiding this comment.
note to self: add rule on " '. Surprised the default airbnb we use doesn't have an opinion....
src/RestQuery.js
Outdated
| @@ -552,6 +558,29 @@ RestQuery.prototype.runCount = function() { | |||
| }); | |||
| }; | |||
|
|
|||
| RestQuery.prototype.handleIncludeAll = function() { | |||
There was a problem hiding this comment.
function block comment would be nice....
src/RestQuery.js
Outdated
| } | ||
| // Add fields to include, keys, remove dups | ||
| this.include = [...new Set([...this.include, ...includeFields])]; | ||
| if (this.keys) { |
There was a problem hiding this comment.
comment like:
// if this.keys not set, then all keys already included
assuming I've got that right.
|
@acinader Added the changes |
acinader
approved these changes
Jun 16, 2018
8 tasks
This was referenced Aug 24, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4644
Includes all pointers without having to use multiple
include().Let me know if there is a better way to implement it.