Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure read preference is never overriden, so DB config prevails #4833

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Ensure read preference is never overriden, so DB config prevails #4833

merged 1 commit into from
Jun 13, 2018

Conversation

flovilmart
Copy link
Contributor

Fixes #4831

@flovilmart flovilmart requested review from acinader and dplewis June 13, 2018 17:33
@codecov
Copy link

codecov bot commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #4833 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4833      +/-   ##
==========================================
- Coverage   92.74%   92.74%   -0.01%     
==========================================
  Files         119      119              
  Lines        8722     8721       -1     
==========================================
- Hits         8089     8088       -1     
  Misses        633      633
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.83% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e29d02...fe0a6c9. Read the comment docs.

acinader
acinader approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right to me.

My assumption is that you added this six months ago to fix some failing tests and then realized that it was whacking a config, so this is to just fix the tests and revert the previous test.....

@flovilmart
Copy link
Contributor Author

Thar’s basically It, the original assumption was that setting PRIMARY was to set back the original behavior, BUT, that was wrong!

@flovilmart flovilmart merged commit 9c9c07f into master Jun 13, 2018
@flovilmart flovilmart deleted the fix/readpreference-default-override branch June 13, 2018 17:51
flovilmart added a commit that referenced this pull request Aug 12, 2018
@flovilmart
Ensure read preference is never overriden, so DB config prevails (#4833)
25ff77c
flovilmart added a commit that referenced this pull request Aug 12, 2018
@flovilmart
Ensure read preference is never overriden, so DB config prevails (#4833)
4d81f8f
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@flovilmart
Ensure read preference is never overriden, so DB config prevails (par…
308aad8 
…se-community#4833)
@davimacedo davimacedo mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

@dplewis dplewis Awaiting requested review from dplewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flovilmart @acinader