Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds session creation code in Auth.js #4574

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

flovilmart
Copy link
Contributor

Small improvement so the session creation code is shared instead of duplicated.

@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #4574 into master will decrease coverage by 0.02%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4574      +/-   ##
==========================================
- Coverage   92.91%   92.88%   -0.03%     
==========================================
  Files         118      118              
  Lines        8491     8486       -5     
==========================================
- Hits         7889     7882       -7     
- Misses        602      604       +2
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 94.56% <ø> (ø) ⬆️
src/Routers/UsersRouter.js 93.02% <100%> (-0.36%) ⬇️
src/Auth.js 100% <100%> (ø) ⬆️
src/Routers/SessionsRouter.js 92.3% <100%> (-1.25%) ⬇️
src/RestWrite.js 93.41% <87.5%> (-0.05%) ⬇️
src/Routers/PushRouter.js 92.85% <0%> (-3.58%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.11% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b754d51...99a6fb2. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovilmart flovilmart merged commit 11c40dc into master Feb 19, 2018
@flovilmart flovilmart deleted the refactor/share-session-creation branch February 19, 2018 16:15
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants