Refactor and deduplicate logic in Users/Sessions Routers. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlutsenko
commented
Feb 12, 2016
- Refactored users.js into UsersRouter
- Refactored sessions.js into SessionsRouter
- Deduplicated a lot of logic that is shared with ClassesRouter
- Updated to ES6 style
b5576a7 to
9b5f3e6
Compare
9b5f3e6 to
9ced7aa
Compare
|
@nlutsenko updated the pull request. |
|
|
||
| getExpressRouter() { | ||
| let router = new PromiseRouter(); | ||
| router.route('GET', '/users', (req) => { return this.handleFind(req); }); |
There was a problem hiding this comment.
Some slightly terser versions would be router.route('GET', '/users', req => this.handleFind(req));or router.route('GET', '/users', this.handleFind.bind(this)); if you prefer
There was a problem hiding this comment.
Love the former, will update then.
9ced7aa to
b2570a9
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 12, 2016
Refactor and deduplicate logic in Users/Sessions Routers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.