Delete field function in Schema.js #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| //Don't allow deleting the default fields. | ||
| if (!fieldNameIsValidForClass(fieldName, className)) { |
There was a problem hiding this comment.
Maybe we can chain this in a huge promise all together and reject in few of them?
Also, you'll be able to throw the error there in this case. Doesn't really matter much though.
There was a problem hiding this comment.
That seems plausible. Next time I'm writing validation code I'll try that style and see if I like it better.
drew-gross
added a commit
that referenced
this pull request
Feb 11, 2016
Delete field function in Schema.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be necessary for PUT /schemas/:classname