Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint before test. #3147

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Conversation

acinader
Copy link
Contributor

Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...

whadda ya think?

Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
@flovilmart
Copy link
Contributor

That seems to be very cool!! I'll check It out tonight. Was afraid the time of test would increase :)

@flovilmart
Copy link
Contributor

first lint:

real	0m9.124s
user	0m9.431s
sys	0m0.479s

subsequent lint (no changes):

real	0m1.623s
user	0m1.509s
sys	0m0.200s

subsequent lint (small change):

real	0m2.779s
user	0m2.137s
sys	0m0.333s

@flovilmart flovilmart merged commit 4d17bed into parse-community:master Nov 30, 2016
@acinader
Copy link
Contributor Author

we might need to start a collection to get you a new machine @flovilmart ;)

➜  parse-server git:(master) time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  7.55s user 0.40s system 112% cpu 7.083 total
➜  parse-server git:(master) time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  1.31s user 0.17s system 103% cpu 1.431 total
➜  parse-server git:(master) ✗ time npm run lint

> parse-server@2.2.25 lint /Users/arthur/code/parse-server
> eslint --cache ./

npm run lint  1.65s user 0.19s system 105% cpu 1.745 total
➜  parse-server git:(master) ✗ 

@flovilmart
Copy link
Contributor

A new MBP 13 with 16gb / 3.1Ghz / 512Gb just arrived :) making the backups on the 2014 ATM :)

@acinader
Copy link
Contributor Author

acinader commented Nov 30, 2016 via email

@flovilmart
Copy link
Contributor

Probably the most useless 200mhz ever

rsouzas pushed a commit to back4app/parse-server that referenced this pull request Dec 3, 2016
Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
Jcarlosjunior pushed a commit to back4app/parse-server that referenced this pull request Dec 13, 2016
Also turn on lint cacheing to make this change painless ;)
add lint cache to gitignore...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants