Adds --cluster support #2596
Merged
Adds --cluster support #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.10% (diff: 100%)@@ master #2596 diff @@
==========================================
Files 98 98
Lines 11956 11956
Methods 1463 1463
Messages 0 0
Branches 1931 1931
==========================================
- Hits 11013 11012 -1
- Misses 943 944 +1
Partials 0 0
|
|
When a forked process exits, the behaviour is a little different to throng which seems to be restarting that process: https://github.com/hunterloftis/throng/blob/master/lib/throng.js#L39 This would be important in keeping a constant number of processes when one of them has a problem. LGTM apart from that and really useful. |
|
Uhh you're right :) so call another fork on('exit'), I'll run some tests locally to see what's going on |
| @@ -85,7 +85,8 @@ if (options.cluster) { | |||
| cluster.fork(); | |||
| } | |||
| cluster.on('exit', (worker, code, signal) => { | |||
| console.log(`worker ${worker.process.pid} died`); | |||
| console.log(`worker ${worker.process.pid} died... Restarting`); | |||
| cluster.fork(); | |||
There was a problem hiding this comment.
@steven-supersolid I believe that will do :)
|
@flovilmart updated the pull request - view changes |
|
Merging as reviewed by @steven-supersolid and side effect less. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to start a mulitprocessed parse-server through cluster when using the CLI.
--clusterto automatically select the number of processes--cluster 2to start 2 processes