-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APNS client #235
Merged
Merged
Add APNS client #235
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
var Parse = require('parse/node').Parse; | ||
// TODO: apn does not support the new HTTP/2 protocal. It is fine to use it in V1, | ||
// but probably we will replace it in the future. | ||
var apn = require('apn'); | ||
|
||
/** | ||
* Create a new connection to the APN service. | ||
* @constructor | ||
* @param {Object} args Arguments to config APNS connection | ||
* @param {String} args.cert The filename of the connection certificate to load from disk, default is cert.pem | ||
* @param {String} args.key The filename of the connection key to load from disk, default is key.pem | ||
* @param {String} args.passphrase The passphrase for the connection key, if required | ||
* @param {Boolean} args.production Specifies which environment to connect to: Production (if true) or Sandbox | ||
*/ | ||
function APNS(args) { | ||
this.sender = new apn.connection(args); | ||
|
||
this.sender.on('connected', function() { | ||
console.log('APNS Connected'); | ||
}); | ||
|
||
this.sender.on('transmissionError', function(errCode, notification, device) { | ||
console.error('APNS Notification caused error: ' + errCode + ' for device ', device, notification); | ||
// TODO: For error caseud by invalid deviceToken, we should mark those installations. | ||
}); | ||
|
||
this.sender.on("timeout", function () { | ||
console.log("APNS Connection Timeout"); | ||
}); | ||
|
||
this.sender.on("disconnected", function() { | ||
console.log("APNS Disconnected"); | ||
}); | ||
|
||
this.sender.on("socketError", console.error); | ||
} | ||
|
||
/** | ||
* Send apns request. | ||
* @param {Object} data The data we need to send, the format is the same with api request body | ||
* @param {Array} deviceTokens A array of device tokens | ||
* @returns {Object} A promise which is resolved immediately | ||
*/ | ||
APNS.prototype.send = function(data, deviceTokens) { | ||
var coreData = data.data; | ||
var expirationTime = data['expiration_time']; | ||
var notification = generateNotification(coreData, expirationTime); | ||
this.sender.pushNotification(notification, deviceTokens); | ||
// TODO: pushNotification will push the notification to apn's queue. | ||
// We do not handle error in V1, we just relies apn to auto retry and send the | ||
// notifications. | ||
return Parse.Promise.as(); | ||
} | ||
|
||
/** | ||
* Generate the apns notification from the data we get from api request. | ||
* @param {Object} coreData The data field under api request body | ||
* @returns {Object} A apns notification | ||
*/ | ||
var generateNotification = function(coreData, expirationTime) { | ||
var notification = new apn.notification(); | ||
var payload = {}; | ||
for (key in coreData) { | ||
switch (key) { | ||
case 'alert': | ||
notification.setAlertText(coreData.alert); | ||
break; | ||
case 'badge': | ||
notification.badge = coreData.badge; | ||
break; | ||
case 'sound': | ||
notification.sound = coreData.sound; | ||
break; | ||
case 'content-available': | ||
notification.setNewsstandAvailable(true); | ||
var isAvailable = coreData['content-available'] === 1; | ||
notification.setContentAvailable(isAvailable); | ||
break; | ||
case 'category': | ||
notification.category = coreData.category; | ||
break; | ||
default: | ||
payload[key] = coreData[key]; | ||
break; | ||
} | ||
} | ||
notification.payload = payload; | ||
notification.expiry = expirationTime; | ||
return notification; | ||
} | ||
|
||
if (typeof process !== 'undefined' && process.env.NODE_ENV === 'test') { | ||
APNS.generateNotification = generateNotification; | ||
} | ||
module.exports = APNS; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
var APNS = require('../APNS'); | ||
|
||
describe('APNS', () => { | ||
it('can generate APNS notification', (done) => { | ||
//Mock request data | ||
var data = { | ||
'alert': 'alert', | ||
'badge': 100, | ||
'sound': 'test', | ||
'content-available': 1, | ||
'category': 'INVITE_CATEGORY', | ||
'key': 'value', | ||
'keyAgain': 'valueAgain' | ||
}; | ||
var expirationTime = 1454571491354 | ||
|
||
var notification = APNS.generateNotification(data, expirationTime); | ||
|
||
expect(notification.alert).toEqual(data.alert); | ||
expect(notification.badge).toEqual(data.badge); | ||
expect(notification.sound).toEqual(data.sound); | ||
expect(notification.contentAvailable).toEqual(1); | ||
expect(notification.category).toEqual(data.category); | ||
expect(notification.payload).toEqual({ | ||
'key': 'value', | ||
'keyAgain': 'valueAgain' | ||
}); | ||
expect(notification.expiry).toEqual(expirationTime); | ||
done(); | ||
}); | ||
|
||
it('can send APNS notification', (done) => { | ||
var apns = new APNS(); | ||
var sender = { | ||
pushNotification: jasmine.createSpy('send') | ||
}; | ||
apns.sender = sender; | ||
// Mock data | ||
var expirationTime = 1454571491354 | ||
var data = { | ||
'expiration_time': expirationTime, | ||
'data': { | ||
'alert': 'alert' | ||
} | ||
} | ||
// Mock registrationTokens | ||
var deviceTokens = ['token']; | ||
|
||
var promise = apns.send(data, deviceTokens); | ||
expect(sender.pushNotification).toHaveBeenCalled(); | ||
var args = sender.pushNotification.calls.first().args; | ||
var notification = args[0]; | ||
expect(notification.alert).toEqual(data.data.alert); | ||
expect(notification.expiry).toEqual(data['expiration_time']); | ||
expect(args[1]).toEqual(deviceTokens); | ||
done(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no max for
deviceTokens
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, internally the library just sends the notifications one by one, so we do not need to have size limitation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍