Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when push is missing configuration #2035

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

Marco129
Copy link
Contributor

Currently, when there are no custom push adapter, default push adapter will be use even without configuration.

var server = new ParseServer({
  appId: '...',
  masterKey: '...',
  serverURL: 'http://localhost:1337/parse',
  ...moreOptions
  // Missing `push` here
});

This would allow sending push with {result: true} but in return is fail status if we look at _PushStatus. Therefore, it is better to provide error message (Missing push configuration) before trying to send the push, developer will not feel confuse and can fix the problem easier.

@codecov-io
Copy link

codecov-io commented Jun 11, 2016

Current coverage is 92.11%

Merging #2035 into master will increase coverage by 0.13%

  1. 2 files (not in diff) in src were modified. more
    • Misses -9
    • Hits +1
@@             master      #2035   diff @@
==========================================
  Files            91         91          
  Lines          6449       6443     -6   
  Methods        1108       1108          
  Messages          0          0          
  Branches       1358       1359     +1   
==========================================
+ Hits           5932       5935     +3   
+ Misses          517        508     -9   
  Partials          0          0          

Powered by Codecov. Last updated by 2cc1b0c...f7efb0e

@ghost
Copy link

ghost commented Jun 13, 2016

@Marco129 updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants