Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres adapter #2012

Merged
merged 44 commits into from
Jun 12, 2016
Merged

Conversation

drew-gross
Copy link
Contributor

@drew-gross drew-gross commented Jun 9, 2016

Ready to be merged after #2021 is merged

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

6 similar comments
@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@facebook-github-bot
Copy link

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@codecov-io
Copy link

codecov-io commented Jun 9, 2016

Current coverage is 91.19%

Merging #2012 into master will decrease coverage by 0.94%

  1. File ...o/MongoCollection.js (not in diff) was modified. more
@@             master      #2012   diff @@
==========================================
  Files            91         92     +1   
  Lines          6445       6517    +72   
  Methods        1108       1146    +38   
  Messages          0          0          
  Branches       1363       1368     +5   
==========================================
+ Hits           5938       5943     +5   
- Misses          507        574    +67   
  Partials          0          0          

Powered by Codecov. Last updated by d559cb2...ba6f828

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

4 similar comments
@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 9, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 11, 2016

@drew-gross updated the pull request.

@drew-gross drew-gross changed the title [WIP] Postgres adapter Postgres adapter Jun 11, 2016
@facebook-github-bot
Copy link

@drew-gross updated the pull request.

1 similar comment
@ghost
Copy link

ghost commented Jun 12, 2016

@drew-gross updated the pull request.

@ghost
Copy link

ghost commented Jun 12, 2016

@drew-gross updated the pull request.

@drew-gross
Copy link
Contributor Author

@flovilmart said it was OK to merge :D

@drew-gross drew-gross merged commit 5518edc into parse-community:master Jun 12, 2016
@drew-gross drew-gross deleted the postgres-adapter branch June 12, 2016 23:35

addFieldIfNotExists(className, fieldName, type) {
// TODO: Doing this in a transaction is probably a good idea.
return this._client.query('ALTER TABLE "GameScore" ADD COLUMN "score" double precision', { className, fieldName })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants