Revert "Log objects rather than JSON stringified objects" #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.91%@@ master #1995 diff @@
==========================================
Files 91 91
Lines 6418 6417 -1
Methods 1096 1096
Messages 0 0
Branches 1346 1346
==========================================
- Hits 5899 5898 -1
Misses 519 519
Partials 0 0
|
|
Skipping review since this is just a revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1922. That PR has some bugs which are causing issue, and it turns out having the full request and response in the logs is very useful for debugging. I think we need to rethink this, maybe we can log on one line when verbose is not enabled, and log everything when verbose is enabled or something like that.
@TylerBrock @spenthil