Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Server 4.10.4 installs multiple graphql modules #7650

Closed
FransGH opened this issue Oct 21, 2021 · 5 comments
Closed

Parse Server 4.10.4 installs multiple graphql modules #7650

FransGH opened this issue Oct 21, 2021 · 5 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@FransGH
Copy link
Contributor

FransGH commented Oct 21, 2021

New Issue Checklist

Issue Description

parse-dashboard/GraphQL-Console brings the error that multiple graphql versions are installed on the server.

Steps to reproduce

in an empty folder type:

npm install parse-server
grep '/graphql":' -A1 package-lock.json

Results in:

    "node_modules/graphql": {
      "version": "14.7.0",
--
    "node_modules/parse-server/node_modules/graphql": {
      "version": "15.4.0",

graphql 15.4.0 is a dependency of parse-server
graphql 14.7.0 is a dependency of of graphql-relay 0.6.0

Actual Outcome

Due to the above, GraphQL Console brings an error that multiple graphql versions are installed on the parse-server, causing it to fail.

Expected Outcome

parse-dashboard/GraphQL-Console should work without errors on a fresh install of parse-server 4.x

Making following changes to parse-server/package.json resolves the issue although it is unclear if this has side effects:

"graphql": "15.5.0",          // from "15.4.0"
"graphql-relay": "0.7.0",  // from "0.6.0"

parse-server 5.x seems to fix these dependencies however since it is a major upgrade with possible breaking changes, it would be great if this could be addressed in a 4.10.x update.

Environment

parse-server 4.10.4
parse-dashboard 3.2.1
mongodb 4.4.3
macOS Catalina 10.15.7
node 12.22.6
npm 8.1.0

Logs

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 21, 2021

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added severity:low type:bug Impaired feature or lacking behavior that is likely assumed labels Oct 23, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 23, 2021

Do you want to open a PR against the 4.x branch to bump the graphql dependencies?

@mtrezza mtrezza changed the title Clean install of parse-server@4.10.4 installs multiple graphql modules causing GraphQL Console to fail Parse Server 4.10.4 installs multiple graphql modules Oct 23, 2021
FransGH added a commit to FransGH/parse-server that referenced this issue Oct 27, 2021
@FransGH
Copy link
Contributor Author

FransGH commented Oct 27, 2021

First PR so hope this is ok? #7658

@mtrezza
Copy link
Member

mtrezza commented Oct 27, 2021

Amazing, I'll review.

FransGH pushed a commit to FransGH/parse-server that referenced this issue Oct 27, 2021
@mtrezza
Copy link
Member

mtrezza commented Feb 12, 2022

Closing via #7658.

@mtrezza mtrezza closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

2 participants