-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dev flag #962
Adds dev flag #962
Conversation
when running with docker, as the local IP address is different from the dashboard all the security features would light up. This --dev flag let anyone run the dashboard locally easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems fine to me.
Why would this be needed. How is this different from allowInsecureHTTP option?
Parse-Dashboard/index.js
Outdated
@@ -35,6 +36,8 @@ const mountPath = program.mountPath || process.env.MOUNT_PATH || '/'; | |||
const allowInsecureHTTP = program.allowInsecureHTTP || process.env.PARSE_DASHBOARD_ALLOW_INSECURE_HTTP; | |||
const cookieSessionSecret = program.cookieSessionSecret || process.env.PARSE_DASHBOARD_COOKIE_SESSION_SECRET; | |||
const trustProxy = program.trustProxy || process.env.PARSE_DASHBOARD_TRUST_PROXY; | |||
const dev = program.dev; | |||
console.log(dev); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.
Also, should probably make an env key too. PARSE_DEV?
This is different as it allows for bypassing user authentication requirement |
right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment on console.log above
when running with docker, as the local IP address is different from the dashboard
all the security features would light up.
This --dev flag let anyone run the dashboard locally easily