-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies + related changes. #1103
Updated dependencies + related changes. #1103
Conversation
Important notes: - minSDK set to API 28 as I prioritize security and adopting new standards over supporting old insecure platforms. - Old module GCM removed. - jacoco disabled as using the compiled version over jitpack leads to compilation errors which I could not fix so far.
…d + dependencies updated and unneeded anymore removed.
The build is failing, I took a look but I'm not experienced with that system, locally it compiles without problem, and using it in a test proyect also work. |
@L3K0V Is this PR still needed after #1095? |
@mobilekosmos did good job here, but most of it was already covered by the #1095 @mtrezza |
Is there anything that can/should be taken from this PR? Or is it better to close it and start fresh, given the many changes that were merged in #1095? |
@mtrezza let's close it and I will encourage @mobilekosmos to check again and open PR with further improvements if any |
Oh noooo, I worked like 1 week updating all, #1095 doesn't even update the gradle plugin. |
reopened 🙂 do you want to bring this up-to-date with master?
This is actually a good point. We should remove support for APIs that are out of long-term-support. We do the same with Node.js and MongoDB for Parse Server. This also gives us a guidance for how long to support APIs. What is the lowest maintained Android API? |
Despite above declaration I won't go to that extrem, since it's not my library I would say minSDK=26 (Android 8.0), that's like already 6 years old. Would it be my own library I would be more agressive and set mindSDK=28 Btw. I made another branch where I will try to merge the current master. Will then do a new PR. |
Sounds good, so I'll close this PR again. |
I'm also for updating the version to SDK 21 but also OkHttp should be updated as well for sure when updating the SDK version. @mobilekosmos do you want to handle this in your PR - updating do SDK 21 and updating the OkHttp to latest version? |
How we set the API versions liked requires a discussion. I opened #1123 for that. |
Notes: