generated from Bullrich/parity-action-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up to date action got into an infinite loop commenting(flooding) the PR #18
Labels
bug
Something isn't working
Comments
I found the issue. Auto-Merge-Bot is being triggered every time a comment appears, even tho it is skipped because it doesn't start with The Up-to-date.yml subscribed to the event being triggered name: Keep PR up to date
on:
push:
branches:
- main
workflow_run:
workflows: [Auto Merge Bot]
types: [completed] But it seems it can not distinct a There are only three events:
It seems that skipped was considered The problem in detail
Solutions
|
Bullrich
added a commit
to Bullrich/polkadot-fellows-runtimes
that referenced
this issue
May 21, 2024
As explained in paritytech/up-to-date-action#18, the issue is caused because the `skipped` event is treated as `completed`. Until a better solution is generated, let's remove this event and triggered it only in pushes. This reverts polkadot-fellows#272
1 task
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this issue
May 22, 2024
As explained in paritytech/up-to-date-action#18 (comment), the issue is caused because the `skipped` event is treated as `completed`. Until a better solution is generated, let's remove this event and trigger it only in pushes. This reverts #272 - [x] Does not require a CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
polkadot-fellows/runtimes#290
The action was re-triggering and failing with error
Not sure if we can overcome that error, but certainly it must not re-trigger infinitelly
The text was updated successfully, but these errors were encountered: