Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-proxy: emit events on proxy added. #9546

Merged
3 commits merged into from
Aug 25, 2021
Merged

pallet-proxy: emit events on proxy added. #9546

3 commits merged into from
Aug 25, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Aug 12, 2021

No description provided.

xlc
xlc reviewed Aug 12, 2021
View reviewed changes
frame/proxy/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested review from shawntabrizi and gui1117 August 12, 2021 13:40
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 12, 2021
gui1117
gui1117 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good to me,
maybe this could also be achieve by looking at successful transaction of add_proxy_delegate.

@shaunxw
Copy link
Contributor Author

shaunxw commented Aug 23, 2021

pls review :]

@bkchr
Copy link
Member

bkchr commented Aug 25, 2021

@shaunxw please run cargo fmt to make the CI happy :P

@shaunxw
Copy link
Contributor Author

shaunxw commented Aug 25, 2021

it seems CI is happy with format now

@gui1117
Copy link
Contributor

gui1117 commented Aug 25, 2021

bot merge

@ghost
Copy link

ghost commented Aug 25, 2021

Trying merge.

@ghost ghost merged commit b1a7585 into paritytech:master Aug 25, 2021
@shaunxw shaunxw deleted the sw/add-proxy-event branch August 25, 2021 10:49
Wizdave97 pushed a commit to Wizdave97/substrate that referenced this pull request Aug 25, 2021
@shaunxw @Wizdave97
pallet-proxy: emit events on proxy added. (paritytech#9546)
61347ee 
* pallet-proxy: emit events on proxy added.

* Apply review suggestions.
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xlc xlc xlc left review comments

@gui1117 gui1117 gui1117 approved these changes

@bkchr bkchr bkchr approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaunxw @bkchr @gui1117 @xlc