This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Revert storage cache optimization #8535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c2eaac to
ee3d20e
Compare
bkchr
approved these changes
Apr 6, 2021
andresilva
approved these changes
Apr 6, 2021
bkchr
pushed a commit
that referenced
this pull request
Apr 6, 2021
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Revert "Fixes `storage_hash` caching issue and enables better caching for Cumulus (paritytech#8518)" This reverts commit 85eef08. * Fix reverting storage_hash * Restore test
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
* Revert "Fixes `storage_hash` caching issue and enables better caching for Cumulus (paritytech#8518)" This reverts commit 85eef08. * Fix reverting storage_hash * Restore test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts optimization introduced in #8518, leaving the actual fix.
The optimization proved to be unsound, doe to the fact that
retracteddoes not really reflect cache "reorg" which should happen even though chain reorg does not.To properly account for cumulus case, a different implementation of the cache system would be needed eventually.