This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
No longer display the legacy representation of the PeerId #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Sep 29, 2020
romanb
approved these changes
Sep 29, 2020
|
bot merge |
|
Trying merge. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite #7077, I thought it might still be useful to see the legacy representation of the
PeerId.However, since
Borrow::borrowno longer returns a hashed version of thePeerId, the log message touched in this PR ends up printing the same string twice.Rather than going through complicated means to properly show the legacy
PeerId, I propose to just remove it.