Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce toy runtime for testing inside substrate. #66

Merged
merged 12 commits into from
Feb 9, 2018

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Feb 8, 2018

Also:

  • Refactor the runtime's support modules into a separate crate for deduping with the toy runtime in substrate.
  • Removed some old code (StaticHex in favour of hex_literal).
  • Rename Slicable::to_vec to encode.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Feb 8, 2018
(&b"sta:spe"[..], vec![].join(&self.sessions_per_era)),
(&b"sta:vac"[..], vec![].join(&(self.validators.len() as u32))),
(&b"sta:era"[..], vec![].join(&0u64)),
(&b"gov:apr"[..], vec![].and(&self.approval_ratio)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wishlist: replace all these vec![].and(x) lines with something like encode(x)

/// How much to send.
pub amount: u64,
/// How much to send.
pub nonce: u64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment on nonce

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gavofyork
Copy link
Member Author

cc @rphmeier

@rphmeier
Copy link
Contributor

rphmeier commented Feb 8, 2018

shouldn't it be built on #68 ?

@arkpar arkpar self-assigned this Feb 9, 2018
@arkpar arkpar self-requested a review February 9, 2018 10:57
@arkpar arkpar removed their assignment Feb 9, 2018
@gavofyork gavofyork merged commit 74a897d into master Feb 9, 2018
@gavofyork gavofyork deleted the gav-split-executor branch February 9, 2018 12:24
tomaka pushed a commit to tomaka/polkadot that referenced this pull request Feb 6, 2019
* Update to latest substrate

* Fix as much as I can

* Store key out of Environment::init

* Fix service compile
JoshOrndorff referenced this pull request in moonbeam-foundation/substrate Apr 21, 2021
iStrike7 referenced this pull request in gasp-xyz/substrate Aug 3, 2021
iStrike7 referenced this pull request in gasp-xyz/substrate Aug 3, 2021
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants