This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6415
This PR updates the logic in the Staking Pallet to require that the controller account is alive and stays alive. This requirement already implicitly exists for stash accounts.
To do this, we introduce a check on the
controller
account inbond
andset_controller
to make sure the the account is notis_dead_account()
. After passing this check, we place a reference counter on the controller, forcing it to stay alive as long as it stays a controller.To make sure the account can later be killed, we remove the reference counter from old controllers in
set_controller
andkill_stash
.Tests have been added and updated to verify this behavior.