This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use storage::append in the implementation of the storage types
#5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
reviewed
May 5, 2020
| @@ -526,47 +526,47 @@ mod test_append_and_len { | |||
| #[test] | |||
| fn append_works() { | |||
There was a problem hiding this comment.
kill + append
overwrite + append
would be nice additions to this test
There was a problem hiding this comment.
overwrite + append
Is done below inappend_overwrites_invalid_data
NikVolf
approved these changes
May 5, 2020
|
/bench import/full |
|
Finished benchmark for branch: bkchr-storage-append-improvements Benchmark: Import Benchmark (Full block with wasm, for weights validation) Master: 1333.89 ms |
|
polkadot not building? |
|
Yeah, already working on a companion. |
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Companion pr for Substrate paritytech#5889 * Update Substrate ref
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves all the
append_*functions to use the newstorage::appendfunctionality. This should improve the performance of all these calls. Besides that the host implementation is changed to use theEncodeAppendfromparity-scale-codecinstead of copying it.The implementation comes with some "disadvantages":
appendwill overwrite it and also ignores any default value set in the runtime. Sadly there isn't a better solution for this, but we also should teach people that vectors etc should not get any special default values.appendone item at a time. Up to now, there was only one call toappendthat tried to append more items.