This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Reputation penalty for sending empty block response #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Apr 28, 2020
| @@ -696,6 +699,10 @@ impl<B: BlockT> ChainSync<B> { | |||
| } | |||
| PeerSyncState::DownloadingStale(_) => { | |||
| peer.state = PeerSyncState::Available; | |||
| if blocks.is_empty() { | |||
There was a problem hiding this comment.
Why are we not doing this for the other states as well?
There was a problem hiding this comment.
When doing full sync it is not that critical, as we'll get new blocks from other peers eventually.
|
bot merge |
|
Cannot merge; please ensure the pull request is mergeable and has approval from the project owner or at least 2 core devs. |
|
bot merge cancel |
|
bot merge |
|
Cannot merge; please ensure the pull request is mergeable and has approval from the project owner or at least 2 core devs. |
|
bot merge cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the following scenario:
Currently there's no penalty and the same request will be issues again.