This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Require fn token in decl_storage get
#5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fn` token was already for quite some time as an optional parameter. It was introduced to make these functions better findable. This pr makes the `fn` token required.
xlc
reviewed
Apr 21, 2020
frame/support/src/lib.rs
Outdated
| @@ -271,7 +271,7 @@ mod tests { | |||
| map hasher(identity) T::BlockNumber => T::BlockNumber; | |||
| pub GenericData2 get(fn generic_data2): | |||
| map hasher(blake2_128_concat) T::BlockNumber => Option<T::BlockNumber>; | |||
| pub GetterNoFnKeyword get(no_fn): Option<u32>; | |||
| pub GetterNoFnKeyword get(fn no_fn): Option<u32>; | |||
There was a problem hiding this comment.
GetterNoFnKeyword should just remove this?
gui1117
approved these changes
Apr 21, 2020
kianenigma
approved these changes
Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fntoken was already for quite some time as an optional parameter.It was introduced to make these functions better findable. This pr makes
the
fntoken required.