-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Pass max-total to RewardRemainder on end_era #5697
Conversation
If this pr is accepted, we should update the tests and make sure that this code is not removed a second time ;) |
ok indeed Staking::RewardRemainder::on_unbalance was called with reward_for_max_inflation - reward_for_current_inflation. So maybe in a following PR but I think we should improve doc on the trait saying that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve if merged as is I'll make a new PR with tests and doc, I'm currently working on pushing test on this branch
also in the previous code an event was send with this value maybe better to revive it as well. substrate/frame/staking/src/lib.rs Line 1429 in 870540b
|
I add doc and test, someone should review this few new lines and then we can merge |
Alternative to #5696 since it currently affects Kusama, no era rewards remainders are received
substrate/frame/staking/src/lib.rs
Lines 1428 to 1432 in 870540b