Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Listen on ipv6 addesses by default as well #5677

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 16, 2020

Instead of just listening on ipv4 by default, this enables listening on
ipv6 as well. While doing this, it also fixes a bug which lead to always
listen on all sockets, even if we specify listen addresses explicitly.

Partially fixes: #5645

Instead of just listening on ipv4 by default, this enables listening on
ipv6 as well. While doing this, it also fixes a bug which lead to always
listen on all sockets, even if we specify listen addresses explicitly.
@bkchr bkchr added A0-please_review Pull request needs code review. B1-clientnoteworthy labels Apr 16, 2020
@bkchr bkchr requested a review from tomaka April 16, 2020 20:41
@bkchr bkchr requested a review from cecton as a code owner April 16, 2020 20:41
Copy link
Contributor

@cecton cecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

I think I introduced that bug/regression 😓

@gavofyork gavofyork merged commit 0354855 into master Apr 17, 2020
@gavofyork gavofyork deleted the bkchr-ipv6-listen branch April 17, 2020 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind to IPv6 addresses if available
5 participants