Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Adjustments to Kademlia-related metrics #5660

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Adjustments to Kademlia-related metrics #5660

merged 5 commits into from
Apr 17, 2020

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 16, 2020 •
edited
Loading

Adjusts some Kademlia-related metrics to #5045, and adds more metrics related to the Kademlia records store:

  • kbuckets_num_nodes now has a protocol parameter, to differentiate between DHTs.
  • Renamed random_kademalia_queries_total (note the typo) to kademlia_random_queries_total.
  • Added kademlia_records_count and kademlia_records_sizes_total metrics.

@tomaka tomaka added A0-please_review Pull request needs code review. B1-clientnoteworthy labels Apr 16, 2020
@tomaka tomaka requested a review from mxinden April 16, 2020 10:07
andresilva
andresilva approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but someone else with more knowledge about this code should have a look.

@bkchr bkchr merged commit 6313868 into paritytech:master Apr 17, 2020
@tomaka tomaka deleted the kbuckets-entries-to-gauge-vec branch April 17, 2020 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomaka @andresilva @mxinden @bkchr