This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Prometheus Metrics: Turn notifications_total counter into notifications_sizes histogram #5535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Apr 6, 2020
client/network/src/service.rs
Outdated
| "sub_libp2p_notifications_sizes", | ||
| "Sizes of the notifications send to and received from all nodes" | ||
| ), | ||
| buckets: vec![64.0, 256.0, 1024.0, 4.0 * 1024.0, 64.0 * 1024.0, 256.0 * 1024.0, 1024.0 * 1024.0], |
There was a problem hiding this comment.
Suggested change
| buckets: vec![64.0, 256.0, 1024.0, 4.0 * 1024.0, 64.0 * 1024.0, 256.0 * 1024.0, 1024.0 * 1024.0], | |
| buckets: vec![64.0, 256.0, 1024.0, 4.0 * 1024.0, 16.0 * 1024.0, 64.0 * 1024.0, 256.0 * 1024.0, 1024.0 * 1024.0], |
Aren't you missing this one here?
Also why not use https://docs.rs/prometheus/0.8.0/prometheus/fn.exponential_buckets.html?
mxinden
approved these changes
Apr 6, 2020
|
benchmark test failing. please merge master. (changed title and tag to have it show up nicely in the changelogs) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reporting just the number of notifications sent and received through a counter, this PR now also reports their sizes in bytes through a histogram.
Consequently I renamed
notifications_totaltonotifications_sizes.