This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
contracts: New contract events + unconfusions #4685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message confused many people so we are improving it to make clear what happened.
It looks like @Robbepop signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Robbepop
changed the title
Robin contracts unconfuse msg
contracts: New contract events + unconfusions
Jan 20, 2020
gui1117
reviewed
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it miss some evicted event, otherwise looks good
pepyakin
reviewed
Jan 20, 2020
pepyakin
reviewed
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Would be great if some tests for these events were provided!
gui1117
reviewed
Jan 20, 2020
gui1117
approved these changes
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :-)
pepyakin
approved these changes
Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves contracts PALLET by
Restored
andEvicted
Event::Evicted(AccountId, bool)
contract: AccountID
: The account ID of the evicted contract.tombstone: bool
: True if the evicted contract left behind a tombstone.Event::Restored(AccountId, AccountId, Hash, Balance, bool)
donor: AccountId
: The Account ID of the restoring contractdest: AccountId
: The account ID of the restored contractcode_hash: Hash
: The code hash of the restored contractrent_allowance: Balance
: The initial rent allowance of the restored contractsuccess: bool
: If restoration was successfulEvent::Contract
toEvent::ContractExecution
so that it is clear that the event was triggered by a contract execution"during execution"
)