Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add rules and unfounding to society. #4671

Merged
merged 6 commits into from
Jan 18, 2020
Merged

Conversation

gavofyork
Copy link
Member

No description provided.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Jan 18, 2020
@gavofyork
Copy link
Member Author

@NikVolf feel free to approve otherwise :)

Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intention of unfound is to close a society before it ever begins, then this looks good.

Once society has begun, this function will not become callable because Founder will never become Head again.

@gavofyork gavofyork merged commit 8131288 into master Jan 18, 2020
@gavofyork gavofyork deleted the gav-society-unfound-rules branch January 18, 2020 17:35
gavofyork added a commit that referenced this pull request Jan 18, 2020
* Add rules and unfounding to society.

* Docs and event

* Extra bit of docs.

* Cunningly reduce complexity

* Remove candidates when unfounding.

* Remove suspended candidates when unfounding, too.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants