This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Patch practical usability issues with Society #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
commented
Jan 16, 2020
shawntabrizi
commented
Jan 17, 2020
bin/node/cli/src/chain_spec.rs
Outdated
| @@ -295,6 +295,11 @@ pub fn testnet_genesis( | |||
| }), | |||
| pallet_membership_Instance1: Some(Default::default()), | |||
| pallet_treasury: Some(Default::default()), | |||
| pallet_society: Some(SocietyConfig { | |||
| members: endowed_accounts[0..3].to_vec(), | |||
| pot: 100000, | |||
There was a problem hiding this comment.
Double check this number
There was a problem hiding this comment.
pot should probably just be zero.
max_members
why not to a straight |
bkchr
approved these changes
Jan 17, 2020
| @@ -72,6 +72,7 @@ pallet-transaction-payment = { version = "2.0.0", path = "../../../frame/transac | |||
| frame-support = { version = "2.0.0", default-features = false, path = "../../../frame/support" } | |||
| pallet-im-online = { version = "2.0.0", default-features = false, path = "../../../frame/im-online" } | |||
| pallet-authority-discovery = { version = "2.0.0", path = "../../../frame/authority-discovery" } | |||
| pallet-society = { version = "2.0.0", path = "../../../frame/society" } | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Currently, if you try to call
foundon the Society pallet on a running chain, it will fail since theMaxMembersstorage item is default 0. This introduces a second parameter to thefoundextrinsic,max_memberswhich will set this value to some non-zero value.The Polkadot JS API does not recognize a storage item with type
Option<()>as everisSome. I change the use ofOption<()>toOption<bool>for tracking suspended members.Option<()>returnsisNonetrue whenSome(())polkadot-js/api#1724This also updates the Substrate node so that Society has a genesis configuration, and thus running a new Substrate node will make society enabled and usable.