-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Expose proof generation and verifying api. #4646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be PR in polkadot ready so that always identical version of trie* dependencies are used
Not sure if it should be part of this PR, but there is also : https://github.com/paritytech/trie/blob/d60e70bdd8c1e62af00459f9301c5002e69aaa21/trie-db/src/lib.rs#L105 that propose a way to have smaller proofs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces everywhere!
This reverts commit 4c3f72f.
Benchmarks need fixing. |
@bkchr yes, that is in process |
@@ -119,6 +121,47 @@ pub mod trie_types { | |||
pub type TrieError<H> = trie_db::TrieError<H, super::Error>; | |||
} | |||
|
|||
/// Create a proof for a subset of keys in a trie. | |||
/// | |||
/// The `keys` may contain any set of keys regardless of each one of them is included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "included into" should be "included in" - here and in other docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than docs nit!
Exposes proof generation and verification from
trie-db
.Bumps
trie-db
andmemory-db
dependencies.